8382397: Make lint category property declaration more straightforward#30776
Open
liach wants to merge 1 commit intoopenjdk:masterfrom
Open
8382397: Make lint category property declaration more straightforward#30776liach wants to merge 1 commit intoopenjdk:masterfrom
liach wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
liach
changed the title
openjdk
Bot
changed the title
Contributor
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint category properties are now declared with confusing boolean variables. We can convert them to be enums to make these declarations more straightforward and easier to check in general.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30776/head:pull/30776$ git checkout pull/30776Update a local copy of the PR:
$ git checkout pull/30776$ git pull https://git.openjdk.org/jdk.git pull/30776/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30776View PR using the GUI difftool:
$ git pr show -t 30776Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30776.diff
Using Webrev
Link to Webrev Comment